From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Date: Thu, 2 Aug 2012 14:51:39 +0000 (+0300)
Subject: tests: ubi: clean-up runtests.sh some more
X-Git-Tag: v1.5.1~68
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f5c83c4a86e94377ad34ef7481b2242c5a5828d4;p=mtd-utils.git

tests: ubi: clean-up runtests.sh some more

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---

diff --git a/tests/ubi-tests/runtests.sh b/tests/ubi-tests/runtests.sh
index 5bd9baa..a69a9bf 100755
--- a/tests/ubi-tests/runtests.sh
+++ b/tests/ubi-tests/runtests.sh
@@ -1,20 +1,30 @@
 #!/bin/sh -euf
 
-ubidev="$1"
 tests="mkvol_basic mkvol_bad mkvol_paral rsvol io_basic io_read io_update io_paral volrefcnt"
 
 fatal()
 {
-	echo "Error: $1" 2>&1
+	echo "Error: $1" 1>&2
 	exit 1
 }
 
-if [ -z "$ubidev" ]; then
-	echo "Usage:" 2>&1
-	echo "$0 <UBI device>"
+usage()
+{
+	cat 1>&2 <<EOF
+Run all UBI tests for on an UBI device.
+Usage:
+  ${0##*/} <UBI device node>
+Example:
+  ${0##*/} /dev/ubi1 - test /dev/ubi1.
+EOF
+}
+
+if [ "$#" -lt 1 ]; then
+	usage
 	exit 1
 fi
 
+ubidev="$1"
 [ -c "$ubidev" ] || fatal "$ubidev is not character device"
 
 for t in $tests; do