From: Hongbo Li <lihongbo22@huawei.com>
Date: Wed, 11 Sep 2024 01:09:27 +0000 (+0800)
Subject: coccinelle: Remove unnecessary parentheses for only one possible change.
X-Git-Tag: nvme-6.12-2024-10-31~26^2~1
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f584e3752ca7bb1f8849a85816b3c974f1aa67ec;p=nvme.git

coccinelle: Remove unnecessary parentheses for only one possible change.

The parentheses are only needed if there is a disjunction, ie a
set of possible changes. If there is only one pattern, we can
remove these parentheses. Just like the format:

  -  x
  +  y

not:

  (
  -  x
  +  y
  )

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---

diff --git a/scripts/coccinelle/api/string_choices.cocci b/scripts/coccinelle/api/string_choices.cocci
index 96dc7090395d..95e9a3b31f86 100644
--- a/scripts/coccinelle/api/string_choices.cocci
+++ b/scripts/coccinelle/api/string_choices.cocci
@@ -43,18 +43,14 @@ coccilib.report.print_report(p[0], "opportunity for str_plural(%s)" % e)
 @str_up_down depends on patch@
 expression E;
 @@
-(
 -	((E) ? "up" : "down")
 +	str_up_down(E)
-)
 
 @str_up_down_r depends on !patch exists@
 expression E;
 position P;
 @@
-(
 *	((E@P) ? "up" : "down")
-)
 
 @script:python depends on report@
 p << str_up_down_r.P;
@@ -66,18 +62,14 @@ coccilib.report.print_report(p[0], "opportunity for str_up_down(%s)" % e)
 @str_down_up depends on patch@
 expression E;
 @@
-(
 -      ((E) ? "down" : "up")
 +      str_down_up(E)
-)
 
 @str_down_up_r depends on !patch exists@
 expression E;
 position P;
 @@
-(
 *      ((E@P) ? "down" : "up")
-)
 
 @script:python depends on report@
 p << str_down_up_r.P;