From: David Woodhouse <dwmw2@infradead.org>
Date: Tue, 15 Aug 2017 16:24:40 +0000 (+0100)
Subject: Heckle gpst_obtain_cookie()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f5528eff07eff9e8e694f8bc34826d1328da0685;p=users%2Fdwmw2%2Fopenconnect.git

Heckle gpst_obtain_cookie()

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
---

diff --git a/auth-globalprotect.c b/auth-globalprotect.c
index ca6748cb..2618f3e1 100644
--- a/auth-globalprotect.c
+++ b/auth-globalprotect.c
@@ -381,6 +381,8 @@ int gpst_obtain_cookie(struct openconnect_info *vpninfo)
 		/* first try handling it as a gateway, then a portal */
 		result = gpst_login(vpninfo, 0);
 		if (result == -EEXIST) {
+			/* XX: Don't we want to start by trying the same username/password the user just
+			   entered for the 'gateway' attempt? */
 			result = gpst_login(vpninfo, 1);
 			if (result == -EEXIST)
 				vpn_progress(vpninfo, PRG_ERR, _("Server is neither a GlobalProtect portal nor a gateway.\n"));