From: Jakub Kicinski Date: Fri, 12 Sep 2025 16:17:03 +0000 (-0700) Subject: page_pool: always add GFP_NOWARN for ATOMIC allocations X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f3b52167a0cb23b27414452fbc1278da2ee884fc;p=users%2Fhch%2Fmisc.git page_pool: always add GFP_NOWARN for ATOMIC allocations Driver authors often forget to add GFP_NOWARN for page allocation from the datapath. This is annoying to users as OOMs are a fact of life, and we pretty much expect network Rx to hit page allocation failures during OOM. Make page pool add GFP_NOWARN for ATOMIC allocations by default. Reviewed-by: Mina Almasry Link: https://patch.msgid.link/20250912161703.361272-1-kuba@kernel.org Signed-off-by: Jakub Kicinski --- diff --git a/net/core/page_pool.c b/net/core/page_pool.c index ba70569bd4b0..36a98f2bcac3 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -555,6 +555,12 @@ static noinline netmem_ref __page_pool_alloc_netmems_slow(struct page_pool *pool netmem_ref netmem; int i, nr_pages; + /* Unconditionally set NOWARN if allocating from NAPI. + * Drivers forget to set it, and OOM reports on packet Rx are useless. + */ + if ((gfp & GFP_ATOMIC) == GFP_ATOMIC) + gfp |= __GFP_NOWARN; + /* Don't support bulk alloc for high-order pages */ if (unlikely(pp_order)) return page_to_netmem(__page_pool_alloc_page_order(pool, gfp));