From: Leon Romanovsky <leonro@mellanox.com>
Date: Mon, 18 Feb 2019 20:25:52 +0000 (+0200)
Subject: RDMA/nldev: Don't expose number of not-visible entries
X-Git-Tag: v5.1-rc1~86^2~43
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f2a0e45f36b0a210ff2388ed5fa89f81019c07a1;p=users%2Fjedix%2Flinux-maple.git

RDMA/nldev: Don't expose number of not-visible entries

Netlink dumpit handshake exchanges the index from which kernel should
start to return its value, in current code, this index included
not-visible in this PID items too and indirectly revealed the number of
entries.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---

diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
index 8b4f86ce50ce..e7350d9d60e9 100644
--- a/drivers/infiniband/core/nldev.c
+++ b/drivers/infiniband/core/nldev.c
@@ -1123,13 +1123,10 @@ static int res_get_common_dumpit(struct sk_buff *skb,
 	 * objects.
 	 */
 	xa_for_each(&rt->xa, id, res) {
-		if (idx < start)
-			goto next;
-
 		if (!is_visible_in_pid_ns(res))
-			goto next;
+			continue;
 
-		if (!rdma_restrack_get(res))
+		if (idx < start || !rdma_restrack_get(res))
 			goto next;
 
 		xa_unlock(&rt->xa);