From: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
Date: Thu, 9 Dec 2021 10:09:09 +0000 (+0100)
Subject: Condition `!dtlsver` is true after `else if (dtlsver)`
X-Git-Tag: v9.00~62^2~1
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f1c1aed6cae184ef9c5f35b3f0980e2edb921d34;p=users%2Fdwmw2%2Fopenconnect.git

Condition `!dtlsver` is true after `else if (dtlsver)`

Fixes a Codacy alert:
Condition '!dtlsver' is always false

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
---

diff --git a/openssl-dtls.c b/openssl-dtls.c
index f9b728c1..7685346f 100644
--- a/openssl-dtls.c
+++ b/openssl-dtls.c
@@ -511,7 +511,7 @@ int start_dtls_handshake(struct openconnect_info *vpninfo, int dtls_fd)
 		for (i = 0; i < sk_SSL_CIPHER_num(ciphers); i++) {
 			ssl_ciph = sk_SSL_CIPHER_value(ciphers, i);
 			/* For PSK-NEGOTIATE just use the first one we find */
-			if (!dtlsver || !strcmp(SSL_CIPHER_get_name(ssl_ciph), cipher))
+			if (!strcmp(SSL_CIPHER_get_name(ssl_ciph), cipher))
 				break;
 		}