From: Paolo Bonzini <pbonzini@redhat.com>
Date: Sat, 25 May 2024 08:03:22 +0000 (+0200)
Subject: target/i386: no single-step exception after MOV or POP SS
X-Git-Tag: pull-vmclock-20250108~309^2~21
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f0f0136abba688a6516647a79cc91e03fad6d5d7;p=users%2Fdwmw2%2Fqemu.git

target/i386: no single-step exception after MOV or POP SS

Intel SDM 18.3.1.4 "If an occurrence of the MOV or POP instruction
loads the SS register executes with EFLAGS.TF = 1, no single-step debug
exception occurs following the MOV or POP instruction."

Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index ebcff8766c..9782250b20 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -2273,7 +2273,7 @@ gen_eob_worker(DisasContext *s, bool inhibit, bool recheck_tf, bool jr)
     if (recheck_tf) {
         gen_helper_rechecking_single_step(tcg_env);
         tcg_gen_exit_tb(NULL, 0);
-    } else if (s->flags & HF_TF_MASK) {
+    } else if ((s->flags & HF_TF_MASK) && !inhibit) {
         gen_helper_single_step(tcg_env);
     } else if (jr &&
                /* give irqs a chance to happen */