From: Chung-Chiang Cheng <shepjeng@gmail.com>
Date: Fri, 18 Jun 2021 07:59:25 +0000 (+0800)
Subject: configfs: fix memleak in configfs_release_bin_file
X-Git-Tag: v5.4.132~18
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=f0acb12b986658e1064bdd46d6d0b9807aba7b33;p=users%2Fdwmw2%2Flinux.git

configfs: fix memleak in configfs_release_bin_file

[ Upstream commit 3c252b087de08d3cb32468b54a158bd7ad0ae2f7 ]

When reading binary attributes in progress, buffer->bin_buffer is setup in
configfs_read_bin_file() but never freed.

Fixes: 03607ace807b4 ("configfs: implement binary attributes")
Signed-off-by: Chung-Chiang Cheng <cccheng@synology.com>
[hch: move the vfree rather than duplicating it]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/fs/configfs/file.c b/fs/configfs/file.c
index 84b4d58fc65f7..66fae1853d998 100644
--- a/fs/configfs/file.c
+++ b/fs/configfs/file.c
@@ -482,13 +482,13 @@ static int configfs_release_bin_file(struct inode *inode, struct file *file)
 					buffer->bin_buffer_size);
 		}
 		up_read(&frag->frag_sem);
-		/* vfree on NULL is safe */
-		vfree(buffer->bin_buffer);
-		buffer->bin_buffer = NULL;
-		buffer->bin_buffer_size = 0;
-		buffer->needs_read_fill = 1;
 	}
 
+	vfree(buffer->bin_buffer);
+	buffer->bin_buffer = NULL;
+	buffer->bin_buffer_size = 0;
+	buffer->needs_read_fill = 1;
+
 	configfs_release(inode, file);
 	return 0;
 }