From: Tomi Valkeinen Date: Mon, 3 Mar 2025 16:02:05 +0000 (+0530) Subject: media: i2c: ds90ub913: Fix returned fmt from .set_fmt() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=ef205273132bdc9bcfa1540eef8105475a453300;p=users%2Fdwmw2%2Flinux.git media: i2c: ds90ub913: Fix returned fmt from .set_fmt() When setting the sink pad's stream format, set_fmt accidentally changes the returned format's code to 'outcode', while the purpose is to only use the 'outcode' for the propagated source stream format. Fixes: c158d0d4ff15 ("media: i2c: add DS90UB913 driver") Cc: stable@vger.kernel.org Signed-off-by: Tomi Valkeinen Signed-off-by: Jai Luthra Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c index fd2d2d5272bfb..1445ebbcc9cab 100644 --- a/drivers/media/i2c/ds90ub913.c +++ b/drivers/media/i2c/ds90ub913.c @@ -450,10 +450,10 @@ static int ub913_set_fmt(struct v4l2_subdev *sd, if (!fmt) return -EINVAL; - format->format.code = finfo->outcode; - *fmt = format->format; + fmt->code = finfo->outcode; + return 0; }