From: Omar Sandoval Date: Thu, 9 Aug 2018 21:40:12 +0000 (-0700) Subject: generic/228: fix restoration of kernel.core_pattern sysctl X-Git-Tag: v2022.05.01~1439 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=ed6826096002fa8e6b35fd4e33c746dc60b0d8f5;p=users%2Fhch%2Fxfstests-dev.git generic/228: fix restoration of kernel.core_pattern sysctl generic/228 changes kernel.core_pattern, so it saves it beforehand in order to restore it. However, it adds an extra space in the process: $ echo \"$(sysctl kernel.core_pattern | awk -F = '{print $NF}')\" " |/usr/lib/systemd/systemd-coredump %P %u %g %s %t %c %h %e" Instead of using awk, just use sysctl -n to only print the value. Signed-off-by: Omar Sandoval Reviewed-by: Eric Sandeen Signed-off-by: Eryu Guan --- diff --git a/tests/generic/228 b/tests/generic/228 index fd0223137..16178c331 100755 --- a/tests/generic/228 +++ b/tests/generic/228 @@ -45,7 +45,7 @@ avail=`df -P $TEST_DIR | awk 'END {print $4}'` [ "$avail" -ge 104000 ] || _notrun "Test device is too small ($avail KiB)" # Suppress core dumped messages -core_pattern=`sysctl kernel.core_pattern | awk -F = '{print $NF}'` +core_pattern=`sysctl -n kernel.core_pattern` ulimit_c=`ulimit -c` sysctl -w kernel.core_pattern=core &>/dev/null ulimit -c 0