From: Minwoo Im <minwoo.im.dev@gmail.com>
Date: Thu, 25 Apr 2019 13:53:01 +0000 (+0900)
Subject: get-telemtry-log: Print nvme status in case err > 0
X-Git-Tag: v1.9~76^2~1
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=ed6653d601f1d51e4582470603273c12e20a87e9;p=users%2Fsagi%2Fnvme-cli.git

get-telemtry-log: Print nvme status in case err > 0

If given 'err' is negative, then it's an internal error so that it needs
to be with perror().  If it's positive, then we can print nvme status
out.

Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
---

diff --git a/nvme.c b/nvme.c
index b15d9aba..b4086951 100644
--- a/nvme.c
+++ b/nvme.c
@@ -360,7 +360,9 @@ static int get_telemetry_log(int argc, char **argv, struct command *cmd, struct
 	}
 
 	err = nvme_get_telemetry_log(fd, hdr, cfg.host_gen, cfg.ctrl_init, bs, 0);
-	if (err) {
+	if (err < 0)
+		perror("get-telemetry-log");
+	else if (err > 0) {
 		show_nvme_status(err);
 		fprintf(stderr, "Failed to acquire telemetry header %d!\n", err);
 		goto close_output;
@@ -394,7 +396,10 @@ static int get_telemetry_log(int argc, char **argv, struct command *cmd, struct
 	 */
 	while (offset != full_size) {
 		err = nvme_get_telemetry_log(fd, page_log, 0, cfg.ctrl_init, bs, offset);
-		if (err) {
+		if (err < 0) {
+			perror("get-telemetry-log");
+			break;
+		} else if (err > 0) {
 			fprintf(stderr, "Failed to acquire full telemetry log!\n");
 			show_nvme_status(err);
 			break;