From: David Woodhouse <dwmw@amazon.co.uk>
Date: Thu, 9 May 2024 22:14:51 +0000 (+0100)
Subject: Input temp offset to 0.1°C; there's too much hysteresis with 0.2°C
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=eb8b6d7eee62eb21bc6083544116af27b1e944ce;p=users%2Fdwmw2%2Fesp32-pool.git

Input temp offset to 0.1°C; there's too much hysteresis with 0.2°C

Also reduce the pump-off time to ten minutes. Half an hour is much too long.
---

diff --git a/pool.yaml b/pool.yaml
index 91e1c51..1e820ca 100644
--- a/pool.yaml
+++ b/pool.yaml
@@ -92,10 +92,10 @@ script:
         // accumulating in the water on the roof even while we vacillate.
         //
         // Having replaced the valve assembly in 2024, the new input sensor
-        // seems to be reading *lower* than the output by about 0.2°C, so we
+        // seems to be reading *lower* than the output by about 0.1°C, so we
         // end up pumping heat into the sky, especially in the evenings. So
         // we now make the correction in the opposite direction.
-        intemp += 0.2;
+        intemp += 0.1;
 
         if (outtemp == intemp)
           return;
@@ -105,10 +105,10 @@ script:
 
         if (id(valve_output).state == want_state) {
             ESP_LOGD("control_valve", "Leaving valve %s", want_state ? "ON" : "OFF");
-            if (!want_state && id(pool_pump).state && now > id(control_valve_last_change) + 1800) {
+            if (!want_state && id(pool_pump).state && now > id(control_valve_last_change) + 600) {
                     auto t = id(sntp_time).now();
                     if (t.is_valid() && t.hour >= 17) {
-                            ESP_LOGD("control_value", "Cold for half an hour. Turning pump off for the night");
+                            ESP_LOGD("control_value", "Cold for ten minutes. Turning pump off for the night");
                             id(pool_pump).turn_off();
                     }
             }