From: Nikos Mavrogiannopoulos <nmav@redhat.com>
Date: Thu, 12 Nov 2020 14:57:51 +0000 (+0100)
Subject: parse_prelogin_xml: removed unnecessary initialization
X-Git-Tag: v8.20~386^2~11
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=e9e0ae555f1fae5ba3891b0d201b041c930b0cf5;p=users%2Fdwmw2%2Fopenconnect.git

parse_prelogin_xml: removed unnecessary initialization

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
---

diff --git a/auth-globalprotect.c b/auth-globalprotect.c
index 5185d474..6f9cbcc0 100644
--- a/auth-globalprotect.c
+++ b/auth-globalprotect.c
@@ -74,7 +74,7 @@ const char *gpst_os_name(struct openconnect_info *vpninfo)
 static int parse_prelogin_xml(struct openconnect_info *vpninfo, xmlNode *xml_node, void *cb_data)
 {
 	struct login_context *ctx = cb_data;
-	struct oc_auth_form *form = ctx->form;
+	struct oc_auth_form *form = NULL;
 	struct oc_form_opt *opt, *opt2;
 	char *prompt = NULL, *username_label = NULL, *password_label = NULL;
 	char *saml_method = NULL, *saml_path = NULL;
@@ -132,7 +132,6 @@ static int parse_prelogin_xml(struct openconnect_info *vpninfo, xmlNode *xml_nod
 	}
 
 	/* Replace old form */
-	free_auth_form(ctx->form);
 	form = ctx->form = calloc(1, sizeof(*form));
 	if (!form) {
 	nomem: