From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 12 Jan 2009 16:08:07 +0000 (-0500)
Subject: ubi-utils: fix warning in fprintf() code
X-Git-Tag: v1.3.0~106
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=e95a99a2c5ffb5ae1bf0f69bc553f591e57815e2;p=mtd-utils.git

ubi-utils: fix warning in fprintf() code

When building with gcc security warnings enabled, the ubimirror.c code
triggers this warning:
./src/ubimirror.c: In function 'main':
./src/ubimirror.c:206: error: format not a string literal and no format arguments

Since the buffer in question should be a straight string anyways, avoid
ugly printf exploits by outputting the string indirectly:
	printf("%s", buffer)

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---

diff --git a/ubi-utils/src/ubimirror.c b/ubi-utils/src/ubimirror.c
index 2cc4596..a20e1af 100644
--- a/ubi-utils/src/ubimirror.c
+++ b/ubi-utils/src/ubimirror.c
@@ -203,7 +203,7 @@ main(int argc, char **argv) {
 		       err_buf, sizeof(err_buf));
 	if( rc ){
 		err_buf[sizeof err_buf - 1] = '\0';
-		fprintf(stderr, err_buf);
+		fprintf(stderr, "%s", err_buf);
 		if( rc < 0 )
 			rc = -rc;
 	}