From: Filipe Manana <fdmanana@suse.com>
Date: Fri, 25 Jul 2025 15:54:49 +0000 (+0100)
Subject: btrfs: fix inode leak on failure to add link to inode
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=e87e953bb20629ca1f008f8146c38e313e5ed319;p=users%2Fjedix%2Flinux-maple.git

btrfs: fix inode leak on failure to add link to inode

If we fail to update the inode or delete the orphan item we leak the inode
since we update its refcount with the ihold() call to account for the
d_instantiate() call which never happens in case we fail those steps. Fix
this by setting 'drop_inode' to true in case we fail those steps.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index af2f9b2c8c851..4ed5ab5d3ac15 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6854,6 +6854,7 @@ static int btrfs_link(struct dentry *old_dentry, struct inode *dir,
 		ret = btrfs_update_inode(trans, BTRFS_I(inode));
 		if (ret) {
 			btrfs_abort_transaction(trans, ret);
+			drop_inode = 1;
 			goto fail;
 		}
 		if (inode->i_nlink == 1) {
@@ -6864,6 +6865,7 @@ static int btrfs_link(struct dentry *old_dentry, struct inode *dir,
 			ret = btrfs_orphan_del(trans, BTRFS_I(inode));
 			if (ret) {
 				btrfs_abort_transaction(trans, ret);
+				drop_inode = 1;
 				goto fail;
 			}
 		}