From: Michael Rubin Date: Thu, 17 Apr 2025 00:32:38 +0000 (+0000) Subject: staging: gpib: hp_82335: struct gpib_interface X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=e86b18d2b1127d33d33cecb7f0e06e6846d033fd;p=users%2Fwilly%2Flinux.git staging: gpib: hp_82335: struct gpib_interface Using Linux code style for struct gpib_interface. Adhering to Linux code style. Reported by checkpatch.pl In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Michael Rubin Link: https://lore.kernel.org/r/20250417003246.84445-11-matchstick@neverthere.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib/hp_82335/hp82335.c index f8e5d785746e..3d08d2f726e1 100644 --- a/drivers/staging/gpib/hp_82335/hp82335.c +++ b/drivers/staging/gpib/hp_82335/hp82335.c @@ -180,7 +180,7 @@ static void hp82335_return_to_local(struct gpib_board *board) tms9914_return_to_local(board, &priv->tms9914_priv); } -static gpib_interface_t hp82335_interface = { +static struct gpib_interface hp82335_interface = { .name = "hp82335", .attach = hp82335_attach, .detach = hp82335_detach,