From: Colin Ian King <colin.king@canonical.com>
Date: Sat, 6 Oct 2018 21:56:58 +0000 (+0100)
Subject: misc: mic: scif: remove redundant check on ret < 0
X-Git-Tag: v4.20-rc1~107^2~31
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=e862faa968400206aae3bf8de0d4beb766498657;p=linux.git

misc: mic: scif: remove redundant check on ret < 0

The check for ret < 0 is redundant as any places prior to this point
where ret is set to an error value the code will exit out of the loop
to the error exit label 'err'.  Remove this redundant dead code.

Detected by CoverityScan, CID#1339528 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/misc/mic/scif/scif_dma.c b/drivers/misc/mic/scif/scif_dma.c
index 03af8b5b7b0d..2d76c200d072 100644
--- a/drivers/misc/mic/scif/scif_dma.c
+++ b/drivers/misc/mic/scif/scif_dma.c
@@ -1035,8 +1035,6 @@ scif_rma_list_dma_copy_unaligned(struct scif_copy_work *work,
 			}
 			dma_async_issue_pending(chan);
 		}
-		if (ret < 0)
-			goto err;
 		offset += loop_len;
 		temp += loop_len;
 		temp_phys += loop_len;