From: Akinobu Mita Date: Thu, 9 May 2019 15:43:17 +0000 (+0900) Subject: nvme-cli: cleanup comments for telemetry log structure X-Git-Tag: v1.9~71 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=e6ce32f86fc072aeb5d92b8cb38ac1abb47dd96f;p=users%2Fsagi%2Fnvme-cli.git nvme-cli: cleanup comments for telemetry log structure This removes three comments for struct nvme_telemetry_log_page_hdr. - The comment on top of the definision doesn't describe more than the struct name itself. - The rsvd1 field has already been verified. - The structures with trailing zero size array are commonly used in nvme-cli, so we don't need special comment for telemetry_dataarea[0]. Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Kenneth Heitke Suggested-by: Kenneth Heitke Signed-off-by: Akinobu Mita --- diff --git a/linux/nvme.h b/linux/nvme.h index f6d73413..2c840b94 100644 --- a/linux/nvme.h +++ b/linux/nvme.h @@ -426,9 +426,6 @@ struct nvme_id_nvmset { struct nvme_nvmset_attr_entry ent[NVME_MAX_NVMSET]; }; -/* Derived from 1.3a Figure 101: Get Log Page – Telemetry Host - * -Initiated Log (Log Identifier 07h) - */ struct nvme_telemetry_log_page_hdr { __u8 lpi; /* Log page identifier */ __u8 rsvd[4]; @@ -436,15 +433,10 @@ struct nvme_telemetry_log_page_hdr { __le16 dalb1; /* Data area 1 last block */ __le16 dalb2; /* Data area 2 last block */ __le16 dalb3; /* Data area 3 last block */ - __u8 rsvd1[368]; /* TODO verify */ + __u8 rsvd1[368]; __u8 ctrlavail; /* Controller initiated data avail?*/ __u8 ctrldgn; /* Controller initiated telemetry Data Gen # */ __u8 rsnident[128]; - /* We'll have to double fetch so we can get the header, - * parse dalb1->3 determine how much size we need for the - * log then alloc below. Or just do a secondary non-struct - * allocation. - */ __u8 telemetry_dataarea[0]; };