From: Colin Ian King <colin.king@canonical.com>
Date: Wed, 5 Apr 2017 12:35:44 +0000 (+0100)
Subject: qed: fix missing break in OOO_LB_TC case
X-Git-Tag: v4.1.12-107.0.20170801_2000~77
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=e6b9abd950e8043ee3602854c7d55a9f76266e42;p=users%2Fjedix%2Flinux-maple.git

qed: fix missing break in OOO_LB_TC case

Orabug: 25933053, 26439680

There seems to be a missing break on the OOO_LB_TC case, pq_id
is being assigned and then re-assigned on the fall through default
case and that seems suspect.

Detected by CoverityScan, CID#1424402 ("Missing break in switch")

Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
---

diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index 4a144ab361b0..a462b8ea65fa 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -1132,6 +1132,7 @@ static int qed_sp_ll2_tx_queue_start(struct qed_hwfn *p_hwfn,
 		break;
 	case OOO_LB_TC:
 		pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OOO);
+		break;
 	default:
 		pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OFLD);
 		break;