From: Phil Reid <preid@electromag.com.au>
Date: Thu, 24 Aug 2017 09:31:06 +0000 (+0800)
Subject: i2c: mux: pca954x: Return error if irq_create_mapping fails
X-Git-Tag: v4.15-rc1~119^2~10^2~7
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=e460617e85db8af533c9f70c9ab94d4fa111b379;p=users%2Fjedix%2Flinux-maple.git

i2c: mux: pca954x: Return error if irq_create_mapping fails

irq_create_mapping can return an error, report error to log and return.
Cleanup will occur in the probe function when an error is returned.

Suggested-by: Peter Rosin <peda@axentia.se>
Acked-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Phil Reid <preid@electromag.com.au>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---

diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
index 14aee65298f7..2ca068d8b92d 100644
--- a/drivers/i2c/muxes/i2c-mux-pca954x.c
+++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
@@ -277,6 +277,10 @@ static int pca954x_irq_setup(struct i2c_mux_core *muxc)
 
 	for (c = 0; c < data->chip->nchans; c++) {
 		irq = irq_create_mapping(data->irq, c);
+		if (!irq) {
+			dev_err(&client->dev, "failed irq create map\n");
+			return -EINVAL;
+		}
 		irq_set_chip_data(irq, data);
 		irq_set_chip_and_handler(irq, &pca954x_irq_chip,
 			handle_simple_irq);