From: Yuesong Li <liyuesong@vivo.com>
Date: Thu, 22 Aug 2024 06:21:58 +0000 (+0800)
Subject: bcachefs: Fix double assignment in check_dirent_to_subvol()
X-Git-Tag: configfs-6.13-2024-11-19~602^2~5
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=dedb2fe37574857c84e9598b9f5272505dedf7af;p=users%2Fhch%2Fconfigfs.git

bcachefs: Fix double assignment in check_dirent_to_subvol()

ret was assigned twice in check_dirent_to_subvol(). Reported by cocci.

Signed-off-by: Yuesong Li <liyuesong@vivo.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/fsck.c b/fs/bcachefs/fsck.c
index 267c2336b115..6801c37ee803 100644
--- a/fs/bcachefs/fsck.c
+++ b/fs/bcachefs/fsck.c
@@ -2006,7 +2006,6 @@ static int check_dirent_to_subvol(struct btree_trans *trans, struct btree_iter *
 	if (ret) {
 		bch_err(c, "subvol %u points to missing inode root %llu", target_subvol, target_inum);
 		ret = -BCH_ERR_fsck_repair_unimplemented;
-		ret = 0;
 		goto err;
 	}