From: Jens Axboe Date: Tue, 25 Jun 2024 01:07:18 +0000 (-0600) Subject: io_uring: signal SQPOLL task_work with TWA_SIGNAL_NO_IPI X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=dbcabac138fdfc730ba458ed2199ff1f29a271fc;p=users%2Fdwmw2%2Flinux.git io_uring: signal SQPOLL task_work with TWA_SIGNAL_NO_IPI Before SQPOLL was transitioned to managing its own task_work, the core used TWA_SIGNAL_NO_IPI to ensure that task_work was processed. If not, we can't be sure that all task_work is processed at SQPOLL thread exit time. Fixes: af5d68f8892f ("io_uring/sqpoll: manage task_work privately") Cc: stable@vger.kernel.org Signed-off-by: Jens Axboe --- diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 154b25b8a613b..c326e2127dd4d 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -1259,8 +1259,8 @@ static void io_req_normal_work_add(struct io_kiocb *req) if (ctx->flags & IORING_SETUP_SQPOLL) { struct io_sq_data *sqd = ctx->sq_data; - if (wq_has_sleeper(&sqd->wait)) - wake_up(&sqd->wait); + if (sqd->thread) + __set_notify_signal(sqd->thread); return; }