From: Marek Behún Date: Sat, 31 Aug 2024 09:20:46 +0000 (+0200) Subject: firmware: turris-mox-rwtm: Use devm_mutex_init() instead of mutex_init() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=db955e0847484c64c6e749659527b5f45b2b5749;p=users%2Fjedix%2Flinux-maple.git firmware: turris-mox-rwtm: Use devm_mutex_init() instead of mutex_init() Use devm_mutex_init() instead of mutex_init(), to properly call mutex_destroy() on probe failure / driver unbind. Signed-off-by: Marek Behún Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20240831092050.23093-13-kabel@kernel.org Signed-off-by: Arnd Bergmann --- diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c index d12e296250222..9f6bda969943d 100644 --- a/drivers/firmware/turris-mox-rwtm.c +++ b/drivers/firmware/turris-mox-rwtm.c @@ -456,7 +456,10 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev) platform_set_drvdata(pdev, rwtm); - mutex_init(&rwtm->busy); + ret = devm_mutex_init(dev, &rwtm->busy); + if (ret) + return ret; + init_completion(&rwtm->cmd_done); rwtm->mbox_client.dev = dev;