From: Daniel Lenski <dlenski@gmail.com>
Date: Fri, 7 Aug 2020 18:34:34 +0000 (-0700)
Subject: Juniper unknown forms with action remediate.cgi seem to indicate TNCC/Host Checker... 
X-Git-Tag: v8.20~399
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=db5142ff068db2ca699a065a15f31fb02b89a094;p=users%2Fdwmw2%2Fopenconnect.git

Juniper unknown forms with action remediate.cgi seem to indicate TNCC/Host Checker failure: log error about this

Suggested at https://gitlab.com/openconnect/openconnect/-/issues/175#note_392561212

Signed-off-by: Daniel Lenski <dlenski@gmail.com>
---

diff --git a/auth-juniper.c b/auth-juniper.c
index 19d43978..f1d66bb0 100644
--- a/auth-juniper.c
+++ b/auth-juniper.c
@@ -755,6 +755,14 @@ int oncp_obtain_cookie(struct openconnect_info *vpninfo)
 				break;
 			}
 		} else {
+			char *form_action = (char *)xmlGetProp(node, (unsigned char *)"action");
+			if (form_action && strstr(form_action, "remediate.cgi")) {
+				vpn_progress(vpninfo, PRG_ERR,
+					     _("Form action (%s) likely indicates that TNCC/Host Checker failed.\n"),
+					     form_action);
+			}
+			free(form_action);
+
 			vpn_progress(vpninfo, PRG_ERR,
 				     _("Unknown form ID '%s'\n"),
 				     form_id);