From: Maurizio Lombardi <mlombard@redhat.com>
Date: Tue, 8 Nov 2022 14:41:14 +0000 (+0100)
Subject: plugins/micron: fix freed memory dereference.
X-Git-Tag: v2.3~43
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=dafa92f94c5dae0bdf795ba71ed5d607eaa5253a;p=users%2Fsagi%2Fnvme-cli.git

plugins/micron: fix freed memory dereference.

dev_close() is already called after the jump to "out".
Calling it 2 times against the same pointer is unsafe because
it will dereference freed memory.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---

diff --git a/plugins/micron/micron-nvme.c b/plugins/micron/micron-nvme.c
index e6f3a8cf..3c0904c4 100644
--- a/plugins/micron/micron-nvme.c
+++ b/plugins/micron/micron-nvme.c
@@ -3168,7 +3168,6 @@ static int micron_internal_logs(int argc, char **argv, struct command *cmd,
     if (telemetry_option) {
         if ((ctrl.lpa & 0x8) != 0x8) {
            printf("telemetry option is not supported for specified drive\n");
-           dev_close(dev);
            goto out;
         }
         int logSize = 0; __u8 *buffer = NULL; const char *dir = ".";