From: Peter Zijlstra <peterz@infradead.org>
Date: Mon, 23 Mar 2020 20:11:14 +0000 (+0100)
Subject: objtool: Avoid iterating !text section symbols
X-Git-Tag: v5.8-rc1~225^2~30
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=da837bd6f1994f780325649e8eee7d9b01c5ee4d;p=users%2Fwilly%2Fxarray.git

objtool: Avoid iterating !text section symbols

validate_functions() iterates all sections their symbols; this is
pointless to do for !text sections as they won't have instructions
anyway.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lkml.kernel.org/r/20200416115119.346582716@infradead.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 923652ba5f9a..e201aa1d01f5 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2551,8 +2551,12 @@ static int validate_functions(struct objtool_file *file)
 	struct section *sec;
 	int warnings = 0;
 
-	for_each_sec(file, sec)
+	for_each_sec(file, sec) {
+		if (!(sec->sh.sh_flags & SHF_EXECINSTR))
+			continue;
+
 		warnings += validate_section(file, sec);
+	}
 
 	return warnings;
 }