From: Ying Liu Date: Tue, 11 Apr 2023 17:09:12 +0000 (+0800) Subject: ASoC: tas5720: add missing unwind goto in tas5720_codec_probe X-Git-Tag: kvm-6.4-2~88^2^2~33 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=d93ee84e3eb5d1afc081e57ca37f1411a01f2c94;p=users%2Fdwmw2%2Flinux.git ASoC: tas5720: add missing unwind goto in tas5720_codec_probe Smatch complains that missing unwind goto in tas5720_codec_probe. When tas5720 has an invalid devtype, it is expected to invoke regulator_bulk_disable to handle the failure. But the default option return an error code directly. Fix it by reusing the probe_fail label. Signed-off-by: Ying Liu Link: https://lore.kernel.org/r/20230411170912.1939906-1-lyre@hust.edu.cn Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/tas5720.c b/sound/soc/codecs/tas5720.c index de6d01c8fdd34..4d27b60bd8043 100644 --- a/sound/soc/codecs/tas5720.c +++ b/sound/soc/codecs/tas5720.c @@ -339,7 +339,8 @@ static int tas5720_codec_probe(struct snd_soc_component *component) break; default: dev_err(component->dev, "unexpected private driver data\n"); - return -EINVAL; + ret = -EINVAL; + goto probe_fail; } if (device_id != expected_device_id)