From: Andreas Gruenbacher Date: Tue, 23 Aug 2016 21:51:39 +0000 (+0200) Subject: generic: Check clearing of SGID in chmod and acl_set_file X-Git-Tag: v2022.05.01~2383 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=d8fe99a265fae2453c09ac6dedc7daa4c10d31bd;p=users%2Fhch%2Fxfstests-dev.git generic: Check clearing of SGID in chmod and acl_set_file Check if SGID is cleared upon chmod / setfacl when the owner is not in the owning group. As of today, the kernel fails to clear SGID in setxattr (which is what acl_set_file is implemented on top of) in that case; see this patch: https://patchwork.kernel.org/patch/9290507/ Signed-off-by: Andreas Gruenbacher Cc: Jan Kara Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- diff --git a/tests/generic/375 b/tests/generic/375 new file mode 100755 index 000000000..f8c3260e5 --- /dev/null +++ b/tests/generic/375 @@ -0,0 +1,81 @@ +#! /bin/bash +# FS QA Test 375 +# +# Check if SGID is cleared upon chmod / setfacl when the owner is not in the +# owning group. +# +#----------------------------------------------------------------------- +# Copyright (c) 2016 Red Hat. All Rights Reserved. +# +# Author: Andreas gruenbacher +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/attr + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_test +_require_runas +_require_acls + +cd $TEST_DIR +testfile=testfile.$seq +rm -f $testfile + +touch $testfile +chown 100:100 $testfile + +echo '*** SGID should remain set (twice)' +chmod 2755 $testfile +_runas -u 100 -g 100 -- chmod 2777 $testfile +stat -c %A $testfile +chmod 2755 $testfile +_runas -u 100 -g 100 -- setfacl -m u::rwx,g::rwx,o::rwx $testfile +stat -c %A $testfile + +echo '*** SGID should be cleared (twice)' +chmod 2755 $testfile +_runas -u 100 -g 101 -- chmod 2777 $testfile +stat -c %A $testfile +chmod 2755 $testfile +_runas -u 100 -g 101 -- setfacl -m u::rwx,g::rwx,o::rwx $testfile +stat -c %A $testfile + +echo '*** Expected failure' +_runas -u 101 -g 101 -- chmod 2777 $testfile + +status=0 +exit diff --git a/tests/generic/375.out b/tests/generic/375.out new file mode 100644 index 000000000..478d0784c --- /dev/null +++ b/tests/generic/375.out @@ -0,0 +1,9 @@ +QA output created by 375 +*** SGID should remain set (twice) +-rwxrwsrwx +-rwxrwsrwx +*** SGID should be cleared (twice) +-rwxrwxrwx +-rwxrwxrwx +*** Expected failure +chmod: changing permissions of 'testfile.375': Operation not permitted diff --git a/tests/generic/group b/tests/generic/group index ef38c3524..2d833a2ba 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -377,3 +377,4 @@ 372 auto quick clone 373 auto quick clone 374 auto quick clone dedupe +375 auto quick acl