From: Felipe Balbi <balbi@ti.com>
Date: Fri, 8 Feb 2013 13:14:16 +0000 (+0200)
Subject: usb: dwc3: core: don't forget to free coherent memory
X-Git-Tag: v3.8.4~68
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=d6539025b73f46c486c6c06f87b778ab3e93e8f8;p=users%2Fjedix%2Flinux-maple.git

usb: dwc3: core: don't forget to free coherent memory

commit d9b4330adec006c2e8907bdcacd9dcc0e8874d18 upstream.

commit 3921426 (usb: dwc3: core: move
event buffer allocation out of
dwc3_core_init()) introduced a memory leak
of the coherent memory we use as event
buffers on dwc3 driver.

If the driver is compiled as a dynamically
loadable module and use constantly loads
and unloads the driver, we will continue
to leak the coherent memory allocated during
->probe() because dwc3_free_event_buffers()
is never called during ->remove().

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 3a4004a620ad..f00c74978b7a 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -575,6 +575,7 @@ static int dwc3_remove(struct platform_device *pdev)
 		break;
 	}
 
+	dwc3_free_event_buffers(dwc);
 	dwc3_core_exit(dwc);
 
 	return 0;