From: James Flowers Date: Mon, 1 Sep 2025 03:04:59 +0000 (-0700) Subject: net/smc: Replace use of strncpy on NUL-terminated string with strscpy X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=d250f14f5f0754ce2d05d9c0ce778e4a51f488b0;p=users%2Fhch%2Fmisc.git net/smc: Replace use of strncpy on NUL-terminated string with strscpy strncpy is deprecated for use on NUL-terminated strings, as indicated in Documentation/process/deprecated.rst. strncpy NUL-pads the destination buffer and doesn't guarantee the destination buffer will be NUL terminated. Signed-off-by: James Flowers Reviewed-by: Simon Horman Reviewed-by: Dust Li Reviewed-by: Mahanta Jambigi Link: https://patch.msgid.link/20250901030512.80099-1-bold.zone2373@fastmail.com Signed-off-by: Jakub Kicinski --- diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c index 76ad29e31d60..b90337f86e83 100644 --- a/net/smc/smc_pnet.c +++ b/net/smc/smc_pnet.c @@ -450,7 +450,7 @@ static int smc_pnet_add_ib(struct smc_pnettable *pnettable, char *ib_name, return -ENOMEM; new_pe->type = SMC_PNET_IB; memcpy(new_pe->pnet_name, pnet_name, SMC_MAX_PNETID_LEN); - strncpy(new_pe->ib_name, ib_name, IB_DEVICE_NAME_MAX); + strscpy(new_pe->ib_name, ib_name); new_pe->ib_port = ib_port; new_ibdev = true;