From: Tokunori Ikegami <ikegami.t@gmail.com>
Date: Fri, 13 Dec 2024 16:19:23 +0000 (+0900)
Subject: ocp: update internal-log command telemetry type description
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=d2487019a0788d1287910499c5f6a16b85269342;p=users%2Fsagi%2Fnvme-cli.git

ocp: update internal-log command telemetry type description

Add host0 and host1 help documentation description.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
---

diff --git a/Documentation/nvme-ocp-internal-log.txt b/Documentation/nvme-ocp-internal-log.txt
index 73933491..26d78ac3 100644
--- a/Documentation/nvme-ocp-internal-log.txt
+++ b/Documentation/nvme-ocp-internal-log.txt
@@ -64,9 +64,10 @@ OPTIONS
 
 -t <type>::
 --telemetry-type=<type>::
-	If set to 1, controller shall capture the Telemetry Host-Initiated data
+	Set the telemetry type to 'host', 'host0', 'host1' or 'controller'.
+	If set to host1, controller shall capture the Telemetry Host-Initiated data
 	representing the internal state of the controller at the time the associated
-	Get Log Page command is processed. If cleared to 0, controller shall not
+	Get Log Page command is processed. If set to host0, controller shall not
 	update this data.
 
 EXAMPLES
diff --git a/completions/_nvme b/completions/_nvme
index f34b36b4..ee548339 100644
--- a/completions/_nvme
+++ b/completions/_nvme
@@ -181,7 +181,7 @@ _nvme () {
 				local _internal_log
 				_internal_log=(
 				/dev/nvme':supply a device to use (required)'
-				--telemetry-type=':Telemetry Type; host or controller generated'
+				--telemetry-type=':Telemetry Type; host, host0, host1 or controller generated'
 				-t':alias for --telemetry-type'
 				--data-area=':Telemetry Data Area; 1 or 2'
 				-a':alias for --data-area'
diff --git a/plugins/ocp/ocp-nvme.c b/plugins/ocp/ocp-nvme.c
index 602e19cd..da3f02cd 100644
--- a/plugins/ocp/ocp-nvme.c
+++ b/plugins/ocp/ocp-nvme.c
@@ -1418,7 +1418,7 @@ static int ocp_telemetry_log(int argc, char **argv, struct command *cmd, struct
 	const char *output_format = "output format normal|json";
 	const char *data_area = "Telemetry Data Area; 1 or 2;\n"
 			"e.g. '-a 1 for Data Area 1.'\n'-a 2 for Data Areas 1 and 2.';\n";
-	const char *telemetry_type = "Telemetry Type; 'host' or 'controller'";
+	const char *telemetry_type = "Telemetry Type; 'host', 'host0', 'host1' or 'controller'";
 
 	struct nvme_dev *dev;
 	int err = 0;
@@ -1486,7 +1486,8 @@ static int ocp_telemetry_log(int argc, char **argv, struct command *cmd, struct
 		else if (!strcmp(opt.telemetry_type, "controller"))
 			tele_type = TELEMETRY_TYPE_CONTROLLER;
 		else {
-			nvme_show_error("telemetry-type should be host or controller.\n");
+			nvme_show_error(
+			    "telemetry-type should be host, host0, host1 or controller.\n");
 			goto out;
 		}
 	} else {