From: Zhihao Cheng <chengzhihao1@huawei.com>
Date: Thu, 9 May 2024 11:41:28 +0000 (+0800)
Subject: mkfs.ubifs: Fix wrong xattr entry type
X-Git-Tag: v2.2.1~8
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=d17b14d953b2ab56c938d6c7829b70b91c736efe;p=mtd-utils.git

mkfs.ubifs: Fix wrong xattr entry type

The type of xattr entry should be regular file, otherwise xattr entry
and xattr inode have inconsistent types.

Fixes: 50044efbd6e713 ("mkfs.ubifs: Add extended attribute support")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
---

diff --git a/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c b/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c
index b91a3e2..f92a1ed 100644
--- a/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c
+++ b/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c
@@ -1243,7 +1243,7 @@ static int add_xattr(struct ubifs_ino_node *host_ino, struct stat *st,
 
 	xent->ch.len = len;
 	xent->padding1 = 0;
-	xent->type = UBIFS_ITYPE_DIR;
+	xent->type = UBIFS_ITYPE_REG;
 	xent->nlen = cpu_to_le16(nm.len);
 
 	memcpy(xent->name, nm.name, nm.len + 1);