From: Qing Huang Date: Mon, 8 Oct 2018 23:50:53 +0000 (-0700) Subject: net/mlx4_core: print firmware version during driver loading X-Git-Tag: v4.1.12-124.31.3~485 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=d13426b347854e3ee520890d709536d5365b7d7d;p=users%2Fjedix%2Flinux-maple.git net/mlx4_core: print firmware version during driver loading When debugging firmware related issues, it's very helpful to have firmware version info printed in the kernel log when the driver is loaded. It's easier to match error/warning messages with different FW versions in the log other than running a separate tool to get the information during remote debugging. Orabug: 28809377 Signed-off-by: Qing Huang Reviewed-by: Håkon Bugge Reviewed-by: Shannon Nelson CC: Gerd Rausch CC: Aru Kolappan CC: Sujatha Srinivasa Gopalan Signed-off-by: Brian Maly --- diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c index ec8d5e0b9efd..fda7a08bcf40 100644 --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c @@ -1518,11 +1518,11 @@ int mlx4_QUERY_FW(struct mlx4_dev *dev) MLX4_GET(lg, outbox, QUERY_FW_MAX_CMD_OFFSET); cmd->max_cmds = 1 << lg; - mlx4_dbg(dev, "FW version %d.%d.%03d (cmd intf rev %d), max commands %d\n", - (int) (dev->caps.fw_ver >> 32), - (int) (dev->caps.fw_ver >> 16) & 0xffff, - (int) dev->caps.fw_ver & 0xffff, - cmd_if_rev, cmd->max_cmds); + mlx4_info(dev, "FW version %d.%d.%03d (cmd intf rev %d), max commands %d\n", + (int)(dev->caps.fw_ver >> 32), + (int)(dev->caps.fw_ver >> 16) & 0xffff, + (int)dev->caps.fw_ver & 0xffff, + cmd_if_rev, cmd->max_cmds); MLX4_GET(fw->catas_offset, outbox, QUERY_FW_ERR_START_OFFSET); MLX4_GET(fw->catas_size, outbox, QUERY_FW_ERR_SIZE_OFFSET);