From: Dimitri Papadopoulos Orfanos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
Date: Thu, 18 Sep 2025 18:15:55 +0000 (+0200)
Subject: Address static analysis warning
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=d0bd0bd25f25af26c60c445131ae7e9dc2834294;p=users%2Fdwmw2%2Fopenconnect.git

Address static analysis warning

gnutls.c:2569:3: warning: The 1st argument to 'close' is <= -2 but should be >= -1 [unix.StdCLibraryFunctions]
 2569 |                 closesocket(vpninfo->ssl_fd);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
./openconnect-internal.h:1176:21: note: expanded from macro 'closesocket'
 1176 | #define closesocket close
      |                     ^

Signed-off-by: Dimitri Papadopoulos Orfanos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
---

diff --git a/gnutls.c b/gnutls.c
index 0ac66226..394a3332 100644
--- a/gnutls.c
+++ b/gnutls.c
@@ -2564,7 +2564,7 @@ void openconnect_close_https(struct openconnect_info *vpninfo, int final)
 		gnutls_deinit(vpninfo->https_sess);
 		vpninfo->https_sess = NULL;
 	}
-	if (vpninfo->ssl_fd != -1) {
+	if (vpninfo->ssl_fd >= 0) {
 		unmonitor_fd(vpninfo, ssl);
 		closesocket(vpninfo->ssl_fd);
 		vpninfo->ssl_fd = -1;