From: Miaohe Lin Date: Wed, 24 Feb 2021 20:10:01 +0000 (-0800) Subject: hugetlbfs: remove useless BUG_ON(!inode) in hugetlbfs_setattr() X-Git-Tag: v5.12-rc1~40^2~8 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=d0146756a0993d3a01407b38cd87d965ccda72c6;p=users%2Fdwmw2%2Flinux.git hugetlbfs: remove useless BUG_ON(!inode) in hugetlbfs_setattr() When we reach here with inode = NULL, we should have crashed as inode has already been dereferenced via hstate_inode. So this BUG_ON(!inode) does not take effect and should be removed. Link: https://lkml.kernel.org/r/20210118110700.52506-1-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Reviewed-by: Mike Kravetz Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index dc4aceffa2c77..71a00dbfa612c 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -761,8 +761,6 @@ static int hugetlbfs_setattr(struct user_namespace *mnt_userns, unsigned int ia_valid = attr->ia_valid; struct hugetlbfs_inode_info *info = HUGETLBFS_I(inode); - BUG_ON(!inode); - error = setattr_prepare(&init_user_ns, dentry, attr); if (error) return error;