From: Bruce Allan Date: Fri, 22 Jul 2011 06:21:41 +0000 (+0000) Subject: e1000e: remove unnecessary check for NULL pointer X-Git-Tag: v2.6.39-400.9.0~619^2~55 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=cfa9b5f1bf9ed4fc2528a2f6fdc2ddb1437b468d;p=users%2Fjedix%2Flinux-maple.git e1000e: remove unnecessary check for NULL pointer The array shadow_ram is never NULL. Signed-off-by: Bruce Allan Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher (cherry picked from commit b9e06f70dc186f8353cc593f2b4609383b3be7a9) Signed-off-by: Joe Jin --- diff --git a/drivers/net/e1000e/ich8lan.c b/drivers/net/e1000e/ich8lan.c index d08dc966becd9..cda1b37fc0688 100644 --- a/drivers/net/e1000e/ich8lan.c +++ b/drivers/net/e1000e/ich8lan.c @@ -2146,8 +2146,7 @@ static s32 e1000_read_nvm_ich8lan(struct e1000_hw *hw, u16 offset, u16 words, ret_val = 0; for (i = 0; i < words; i++) { - if ((dev_spec->shadow_ram) && - (dev_spec->shadow_ram[offset+i].modified)) { + if (dev_spec->shadow_ram[offset+i].modified) { data[i] = dev_spec->shadow_ram[offset+i].value; } else { ret_val = e1000_read_flash_word_ich8lan(hw,