From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Oct 2025 18:36:33 +0000 (+0200)
Subject: smb: client: Use common code in cifs_do_create()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=ce47f7498598f4cf8729a6b93722c98814385e78;p=users%2Fhch%2Fmisc.git

smb: client: Use common code in cifs_do_create()

Use a label once more so that a bit of common code can be better reused
at the end of this function implementation.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Enzo Matsumiya <ematsumiya@suse.de>
Reviewed-by: David Howells <dhowells@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/smb/client/dir.c b/fs/smb/client/dir.c
index f64e992ec724..da5597dbf5b9 100644
--- a/fs/smb/client/dir.c
+++ b/fs/smb/client/dir.c
@@ -200,8 +200,8 @@ static int cifs_do_create(struct inode *inode, struct dentry *direntry, unsigned
 
 	full_path = build_path_from_dentry(direntry, page);
 	if (IS_ERR(full_path)) {
-		free_dentry_path(page);
-		return PTR_ERR(full_path);
+		rc = PTR_ERR(full_path);
+		goto out;
 	}
 
 	/* If we're caching, we need to be able to fill in around partial writes. */