From: Gustavo A. R. Silva Date: Tue, 22 Jan 2019 16:56:36 +0000 (-0600) Subject: mfd: sm501: Fix potential NULL pointer dereference X-Git-Tag: v4.19.31~43 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=ce02d82c4e1aaf2fd6ef40a43e5e7ace3c817088;p=users%2Fdwmw2%2Flinux.git mfd: sm501: Fix potential NULL pointer dereference commit ae7b8eda27b33b1f688dfdebe4d46f690a8f9162 upstream. There is a potential NULL pointer dereference in case devm_kzalloc() fails and returns NULL. Fix this by adding a NULL check on *lookup* This bug was detected with the help of Coccinelle. Fixes: b2e63555592f ("i2c: gpio: Convert to use descriptors") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index a530972c5a7e9..e0173bf4b0dc7 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1145,6 +1145,9 @@ static int sm501_register_gpio_i2c_instance(struct sm501_devdata *sm, lookup = devm_kzalloc(&pdev->dev, sizeof(*lookup) + 3 * sizeof(struct gpiod_lookup), GFP_KERNEL); + if (!lookup) + return -ENOMEM; + lookup->dev_id = "i2c-gpio"; if (iic->pin_sda < 32) lookup->table[0].chip_label = "SM501-LOW";