From: Suraj Kandpal Date: Wed, 6 Aug 2025 03:08:56 +0000 (+0530) Subject: drm/i915/scaler: Fix WA_14011503117 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=cdaecac4fbcb2680e0c4e89f772f20b5bf132ea6;p=users%2Fdwmw2%2Flinux.git drm/i915/scaler: Fix WA_14011503117 This introduces and uses a variable id which is just uninitialized. What really needs to be used is the scaler_id. Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117") Signed-off-by: Suraj Kandpal Reviewed-by: Nemesa Garg Link: https://lore.kernel.org/r/20250806030856.3514127-1-suraj.kandpal@intel.com --- diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c index 1374fa94ff5ce..cd7ebbeb95084 100644 --- a/drivers/gpu/drm/i915/display/skl_scaler.c +++ b/drivers/gpu/drm/i915/display/skl_scaler.c @@ -959,11 +959,12 @@ void adl_scaler_ecc_unmask(const struct intel_crtc_state *crtc_state) struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc); const struct intel_crtc_scaler_state *scaler_state = &crtc_state->scaler_state; - int id; if (!scaler_state && scaler_state->scaler_id == -1) return; - intel_de_write_fw(display, SKL_PS_ECC_STAT(crtc->pipe, id), 1); + intel_de_write_fw(display, + SKL_PS_ECC_STAT(crtc->pipe, scaler_state->scaler_id), + 1); intel_de_write(display, XELPD_DISPLAY_ERR_FATAL_MASK, 0); }