From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Fri, 15 Nov 2024 09:13:58 +0000 (+0300)
Subject: cifs: unlock on error in smb3_reconfigure()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=cda88d2fef7aa7de80b5697e8009fcbbb436f42d;p=users%2Fdwmw2%2Flinux.git

cifs: unlock on error in smb3_reconfigure()

Unlock before returning if smb3_sync_session_ctx_passwords() fails.

Fixes: 7e654ab7da03 ("cifs: during remount, make sure passwords are in sync")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Bharath SM <bharathsm@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
index c614c5d8b15e0..49123f458d0c7 100644
--- a/fs/smb/client/fs_context.c
+++ b/fs/smb/client/fs_context.c
@@ -1008,8 +1008,10 @@ static int smb3_reconfigure(struct fs_context *fc)
 	 * later stage
 	 */
 	rc = smb3_sync_session_ctx_passwords(cifs_sb, ses);
-	if (rc)
+	if (rc) {
+		mutex_unlock(&ses->session_mutex);
 		return rc;
+	}
 
 	/*
 	 * now that allocations for passwords are done, commit them