From: Julia Lawall <Julia.Lawall@inria.fr>
Date: Thu, 7 Sep 2023 09:55:17 +0000 (+0200)
Subject: soc: dove: add missing of_node_put
X-Git-Tag: v6.7-rc1~128^2~2^2
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=cc3b17cabe9fd2881eace5b7b1581914569d62e9;p=users%2Fdwmw2%2Flinux.git

soc: dove: add missing of_node_put

for_each_available_child_of_node performs an of_node_get
on each iteration, so a break out of the loop requires an
of_node_put.

This was done using the Coccinelle semantic patch
iterators/for_each_child.cocci

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---

diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
index ffc5311c0ed8b..6202dbcd20a81 100644
--- a/drivers/soc/dove/pmu.c
+++ b/drivers/soc/dove/pmu.c
@@ -410,13 +410,16 @@ int __init dove_init_pmu(void)
 		struct pmu_domain *domain;
 
 		domain = kzalloc(sizeof(*domain), GFP_KERNEL);
-		if (!domain)
+		if (!domain) {
+			of_node_put(np);
 			break;
+		}
 
 		domain->pmu = pmu;
 		domain->base.name = kasprintf(GFP_KERNEL, "%pOFn", np);
 		if (!domain->base.name) {
 			kfree(domain);
+			of_node_put(np);
 			break;
 		}