From: Qianfeng Rong <rongqianfeng@vivo.com>
Date: Thu, 4 Sep 2025 12:36:46 +0000 (+0800)
Subject: drm/amdkfd: Fix error code sign for EINVAL in svm_ioctl()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=cbda64f3f58027f68211dda8ea94d52d7e493995;p=users%2Fhch%2Fmisc.git

drm/amdkfd: Fix error code sign for EINVAL in svm_ioctl()

Use negative error code -EINVAL instead of positive EINVAL in the default
case of svm_ioctl() to conform to Linux kernel error code conventions.

Fixes: 42de677f7999 ("drm/amdkfd: register svm range")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 521c14c7a789..68ba239b2e5d 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -4261,7 +4261,7 @@ svm_ioctl(struct kfd_process *p, enum kfd_ioctl_svm_op op, uint64_t start,
 		r = svm_range_get_attr(p, mm, start, size, nattrs, attrs);
 		break;
 	default:
-		r = EINVAL;
+		r = -EINVAL;
 		break;
 	}