From: Krzysztof Wilczyński <kw@linux.com>
Date: Tue, 6 Jul 2021 00:31:45 +0000 (+0000)
Subject: PCI: Declare pci_filp_private only when HAVE_PCI_MMAP
X-Git-Tag: howlett/maple/20220722_2~916^2~15^2~6
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=cb2d0f846139b620ff2d11da15daa0eeb581d1a6;p=users%2Fjedix%2Flinux-maple.git

PCI: Declare pci_filp_private only when HAVE_PCI_MMAP

The struct pci_filp_private has no users outside drivers/pci/proc.c and is
only used when HAVE_PCI_MMAP is defined.

Wrap the struct pci_filp_private definition itself in #ifdef HAVE_PCI_MMAP.

Found by cppcheck:

  $ cppcheck --enable=all --force drivers/pci/proc.c
  drivers/pci/proc.c:192:6: style: struct member 'pci_filp_private::write_combine' is never used. [unusedStructMember]

Link: https://lore.kernel.org/r/20210706003145.3054881-1-kw@linux.com
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---

diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
index 9c7edec64f7e2..1a5b75399aa5a 100644
--- a/drivers/pci/proc.c
+++ b/drivers/pci/proc.c
@@ -188,10 +188,12 @@ static ssize_t proc_bus_pci_write(struct file *file, const char __user *buf,
 	return nbytes;
 }
 
+#ifdef HAVE_PCI_MMAP
 struct pci_filp_private {
 	enum pci_mmap_state mmap_state;
 	int write_combine;
 };
+#endif /* HAVE_PCI_MMAP */
 
 static long proc_bus_pci_ioctl(struct file *file, unsigned int cmd,
 			       unsigned long arg)