From: Tan Xiaojun <tanxiaojun@huawei.com>
Date: Thu, 23 Feb 2017 06:04:39 +0000 (+0800)
Subject: perf/core: Fix the perf_cpu_time_max_percent check
X-Git-Tag: v4.1.12-124.31.3~352
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=caac7d1e19c76c62b0a866fdfea9c022c2adb84b;p=users%2Fjedix%2Flinux-maple.git

perf/core: Fix the perf_cpu_time_max_percent check

Use "proc_dointvec_minmax" instead of "proc_dointvec" to check the input
value from user-space.

If not, we can set a big value and some vars will overflow like
"sysctl_perf_event_sample_rate" which will cause a lot of unexpected
problems.

Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: <acme@kernel.org>
Cc: <alexander.shishkin@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/1487829879-56237-1-git-send-email-tanxiaojun@huawei.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
(cherry picked from commit 1572e45a924f254d9570093abde46430c3172e3d)

Orabug: 27823815
CVE: CVE-2017-18255

Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Signed-off-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
---

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 651ce2fe366e..92fc693cf1b4 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -226,7 +226,7 @@ int perf_cpu_time_max_percent_handler(struct ctl_table *table, int write,
 				void __user *buffer, size_t *lenp,
 				loff_t *ppos)
 {
-	int ret = proc_dointvec(table, write, buffer, lenp, ppos);
+	int ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
 
 	if (ret || !write)
 		return ret;