From: Dimitri Papadopoulos Orfanos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
Date: Thu, 18 Sep 2025 18:01:38 +0000 (+0200)
Subject: Address static analysis warning
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c8f5db04ad96c89fa42ac1eeeb6d6862ca480138;p=users%2Fdwmw2%2Fopenconnect.git

Address static analysis warning

esp.c:451:3: warning: The 1st argument to 'close' is <= -2 but should be >= -1 [unix.StdCLibraryFunctions]
  451 |                 closesocket(vpninfo->dtls_fd);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./openconnect-internal.h:1176:21: note: expanded from macro 'closesocket'
 1176 | #define closesocket close
      |                     ^

Signed-off-by: Dimitri Papadopoulos Orfanos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
---

diff --git a/esp.c b/esp.c
index ecc1db0f..33f58649 100644
--- a/esp.c
+++ b/esp.c
@@ -446,7 +446,7 @@ void esp_close(struct openconnect_info *vpninfo)
 {
 	/* We close and reopen the socket in case we roamed and our
 	   local IP address has changed. */
-	if (vpninfo->dtls_fd != -1) {
+	if (vpninfo->dtls_fd >= 0) {
 		unmonitor_fd(vpninfo, dtls);
 		closesocket(vpninfo->dtls_fd);
 		vpninfo->dtls_fd = -1;