From: David Oberhollenzer Date: Sun, 10 Nov 2019 13:56:51 +0000 (+0100) Subject: nanddump: don't leak copied command line arguments X-Git-Tag: v2.1.2~19 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c890094638880072cfa95a06cb1353f0214a11a0;p=mtd-utils.git nanddump: don't leak copied command line arguments For some command line flags, the argument string is copied. Simply writing over the buffer leads to a resource leak if the same flag is specified on the command line more than once. This patch adds a free() call to the old buffer before overwriting it with the new copy. Signed-off-by: David Oberhollenzer --- diff --git a/nand-utils/nanddump.c b/nand-utils/nanddump.c index 2f167bb..841ed67 100644 --- a/nand-utils/nanddump.c +++ b/nand-utils/nanddump.c @@ -162,6 +162,7 @@ static void process_options(int argc, char * const argv[]) start_addr = simple_strtoll(optarg, &error); break; case 'f': + free(dumpfile); dumpfile = xstrdup(optarg); break; case 'l':