From: Ernesto A. Fernández Date: Wed, 19 Jul 2017 04:06:35 +0000 (-0300) Subject: common/attr: fix check for _require_attrs() X-Git-Tag: v2022.05.01~1961 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c82ca8fd263cbdb83f460006547e8cbd8c267d90;p=users%2Fhch%2Fxfstests-dev.git common/attr: fix check for _require_attrs() As of now xfstests decides if a filesystem supports attributes by trying to write one to the mount point. For some reason this fails on reiserfs, making it impossible to run tests that _require_attrs. Fix this by checking against $TEST_DIR/syscalltest instead of $TEST_DIR. This is probably what was intended, since the syscalltest file is touched right before running attr. It is also consistent with how the check for acl support is done. Signed-off-by: Ernesto A. Fernández Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- diff --git a/common/attr b/common/attr index c840ce42a..21ebbcd0c 100644 --- a/common/attr +++ b/common/attr @@ -217,7 +217,7 @@ _require_attrs() # stored on disk. # touch $TEST_DIR/syscalltest - attr -s "user.xfstests" -V "attr" $TEST_DIR > $TEST_DIR/syscalltest.out 2>&1 + attr -s "user.xfstests" -V "attr" $TEST_DIR/syscalltest > $TEST_DIR/syscalltest.out 2>&1 cat $TEST_DIR/syscalltest.out >> $seqres.full if grep -q 'Function not implemented' $TEST_DIR/syscalltest.out; then