From: Sean Young <sean@mess.org>
Date: Thu, 16 Apr 2020 14:22:15 +0000 (+0200)
Subject: media: m88ds3103: error in set_frontend is swallowed and not reported
X-Git-Tag: v5.7.5~248
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c5f6d3ff830470a51bbb38a78767c7b1817f302f;p=users%2Fdwmw2%2Flinux.git

media: m88ds3103: error in set_frontend is swallowed and not reported

[ Upstream commit c4ed27cfed45c16c2dd16c9fa3b883e306177e40 ]

Bail out if registers can not be updated.

Addresses-Coverity-ID: 1461655 ("Code maintainability issues")

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Fixes: e6089feca460 ("media: m88ds3103: Add support for ds3103b demod")
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c
index d2c28dcf6b429..abddab02db9ea 100644
--- a/drivers/media/dvb-frontends/m88ds3103.c
+++ b/drivers/media/dvb-frontends/m88ds3103.c
@@ -980,6 +980,8 @@ static int m88ds3103_set_frontend(struct dvb_frontend *fe)
 			goto err;
 
 		ret = m88ds3103_update_bits(dev, 0xc9, 0x08, 0x08);
+		if (ret)
+			goto err;
 	}
 
 	dev_dbg(&client->dev, "carrier offset=%d\n",