From: Chris Wilson Date: Tue, 13 Mar 2018 00:40:55 +0000 (+0000) Subject: drm/i915: Warn against variable length arrays X-Git-Tag: v4.18-rc1~128^2~20^2~187 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c5c2b11894f4f862cf243b955ac59bb1a5fe61b9;p=users%2Fhch%2Fmisc.git drm/i915: Warn against variable length arrays VLA are strongly discouraged in the kernel due to ambiguity they impose on the limited stack space and security concerns over manipulating the stack frame. Add -Wvla to our compiler flags so that CI rejects them. Signed-off-by: Chris Wilson Cc: Jani Nikula Cc: Joonas Lahtinen Acked-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/20180313004055.25411-2-chris@chris-wilson.co.uk --- diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 4eee91a3a236..fcb8a7b27ae2 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -12,7 +12,7 @@ # Note the danger in using -Wall -Wextra is that when CI updates gcc we # will most likely get a sudden build breakage... Hopefully we will fix # new warnings before CI updates! -subdir-ccflags-y := -Wall -Wextra +subdir-ccflags-y := -Wall -Wextra -Wvla subdir-ccflags-y += $(call cc-disable-warning, unused-parameter) subdir-ccflags-y += $(call cc-disable-warning, type-limits) subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)