From: Kangjie Lu <kangjielu@gmail.com>
Date: Tue, 3 May 2016 20:44:20 +0000 (-0400)
Subject: ALSA: timer: Fix leak in events via snd_timer_user_ccallback
X-Git-Tag: v4.1.12-92~42^2~3
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=c4663036bc2a01bdc94bc1c0e4727e2af9323733;p=users%2Fjedix%2Flinux-maple.git

ALSA: timer: Fix leak in events via snd_timer_user_ccallback

The stack object “r1” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

Orabug: 25059885
CVE: CVE-2016-4578
Mainline v4.7 commit 9a47e9cff994f37f7f0dbd9ae23740d0f64f9fe6
Signed-off-by: Chuck Anderson <chuck.anderson@oracle.com>
---

diff --git a/sound/core/timer.c b/sound/core/timer.c
index 72eb1dd6dc76..c85abca92ece 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -1171,6 +1171,7 @@ static void snd_timer_user_ccallback(struct snd_timer_instance *timeri,
 		tu->tstamp = *tstamp;
 	if ((tu->filter & (1 << event)) == 0 || !tu->tread)
 		return;
+	memset(&r1, 0, sizeof(r1));
 	r1.event = event;
 	r1.tstamp = *tstamp;
 	r1.val = resolution;